OutputHandler v3 #370
Merged
OutputHandler v3 #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milo
force-pushed
the
pull-outputs-v3
branch
3 times, most recently
from
538447f
to
99d7980
Compare
|
Updated to keep |
This was referenced Aug 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This BC break storm can be split on:
OutputHandler receives whole Test instance
So it can reach all its properties, including stout and stderr.
Added
OutputHandler::prepare(Test $test)So it can perform some prepare actions. AFAIK it is "needed" by @jiripudil for PhpStorm plugin, right?
OutputHandler is an abstract class instead of the interfaceOutputHandler is the only one place where someone can hook the Tester. It will help to prevent BC breaks
Dropped runner's
getResults()andgetJobCount()With
OutputHandler::prepare()is easy to count jobs and results by its own. Runner itself does not need this methods.