Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debugger::$showLocation flag has no effect #104

Closed
smuuf opened this issue Feb 26, 2015 · 0 comments
Closed

Debugger::$showLocation flag has no effect #104

smuuf opened this issue Feb 26, 2015 · 0 comments

Comments

@smuuf
Copy link
Contributor

smuuf commented Feb 26, 2015

Yesterday, after I downloaded the new Nette 2.3.0, I have discovered this:

Enabling the $showLocation flag in the Debugger class has no effect when displaying the dump (printed on the page, not in the debug bar). That is: The expected tooltip pointing out the location (file & line number) of the dump() function doesn't show up.

I have managed to pinpoint the candidate causing the problem and it seems to be the break; statement used in the Dumper::findLocation() method: https://github.com/nette/tracy/blob/master/src/Tracy/Dumper.php#L516

If I remove the break; statement, it seems to work - the tooltip is displayed.

The general lack of documentation of/in the code and the fact that the break; statement looks like a part of something bigger keeps me from doing this myself and creating the PR. Therefore I humbly ask anyone, who knows what exactly it does, to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant