-
-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add resize handle to panels #285
Comments
@dg - this is looking awesome - thanks very much! I do have a few issues/tweaks though:
Please let me know if you have any problem reproducing any of these, or have questions as to what I mean. Thanks again! |
IMHO it should be fixed |
Yeah, it look great here too! Thanks again for this - it's a really nice enhancement :) |
@dg - Sorry I just discovered what I think should be considered a bug. I think that it stems from changing the coords system from right-bottom to left-top. The problem is that now when you toggle open a section in a panel and the panel expands its size, much of the panel ends up offscreen to the right and bottom. I think there needs to be a listener (ResizeObserver perhaps) to check if a panel increases in size when a section is toggled open and if so, move its position up and left enough for everything to fit in the viewport. Does that sound reasonable? |
Fixed |
@dg can you please release this? |
Within a few weeks |
Thanks @dg for the toggle position fix (it mostly works - I just need to tweak my custom css I think). A new issue I am seeing is that each time a reload a page, the debug bar moves left. This is with all my custom css disabled: |
@adrianbj This does not happen to me. Can you try to find out what is causing it? |
Sorry, it was due to my replacement of the standard close icon with a custom hide/show icon. It worked as is before, but since the recent changes I now need to add:
after I Anyway, all sorted now. |
Description
I think it would be great to make panels resizable. Unfortunately because the panels are typically positioned based on their bottom/right corner, it's not really possible to make use of css resize property, so a custom solution would be needed that adds a handle to the top left of the panel.
This would be really useful for panels with overflowing content.
The text was updated successfully, but these errors were encountered: