Tracy always starts a session

[jkufner]

Version: 2.4.0+, introduced by 5c46e98

Bug Description

Tracy always starts a session because 5c46e98#diff-be100a67d872789dffa3bfba6144122dR89

Steps To Reproduce

Don't start a session, enable Tracy.

Expected Behavior

Session does not start.

Possible Solution

Remove the start() call from DI container and don't be lazy to check if there is a started session. Such a code don't belong to DI container anyway.

See 5c46e98#diff-be100a67d872789dffa3bfba6144122dR89

[dg]

Can you send PR?

[jkufner]

Maybe. It depends on how deep the session goes. I will give it a try.

[milo]

@jkufner It starts in debug mode only, doesn't?

tracy/src/Bridges/Nette/TracyExtension.php

Lines 106 to 123 in 92b97ca

	if ($this->debugMode) {
	foreach ((array) $this->config['bar'] as $item) {
	if (is_string($item) && substr($item, 0, 1) === '@') {
	$item = new Nette\DI\Statement(['@' . $builder::THIS_CONTAINER, 'getService'], [substr($item, 1)]);
	} elseif (is_string($item)) {
	$item = new Nette\DI\Statement($item);
	}
	$initialize->addBody($builder->formatPhp(
	'$this->getService(?)->addPanel(?);',
	Nette\DI\Helpers::filterArguments([$this->prefix('bar'), $item])
	));
	}
	if (!$this->cliMode && ($name = $builder->getByType(Nette\Http\Session::class))) {
	$initialize->addBody('$this->getService(?)->start();', [$name]);
	$initialize->addBody('Tracy\Debugger::dispatch();');
	}
	}

[jkufner]

@milo Yes, the following line causes the issue:

$initialize->addBody('$this->getService(?)->start();', [$name]); 

[milo]

@jkufner Sorry, my point is: Is it a problem to always start session in debug mode? Tracy "always" needs. Usually it is a session for developer on local machine.

[jkufner]

@milo If there are no errors to report, then there is no reason to have a session stored and a cookie sent to a client. Tracy <2.4 behaves this way.

Always starting a session prevents us from implementing a state-less API and pollutes the server with useless sessions as every request creates a new session because non-browser clients ignore cookies.

[milo]

@jkufner Your server does not run in a production mode?

[jkufner]

@milo Of course not; it is a development server.

[forrest79]

Hi, we have a similar problem and we would appriciate Tracy without session. I prepared PR - just a concept.