Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Bar and BlueScreen Debugger dependency injection #73

Closed
bacinsky opened this issue Oct 17, 2014 · 7 comments
Closed

Add support for Bar and BlueScreen Debugger dependency injection #73

bacinsky opened this issue Oct 17, 2014 · 7 comments

Comments

@bacinsky
Copy link

I wonder why there is no way to set Tracy\Bar and Tracy\BlueScreen into Tracy\Debugger via setter dependency injection. It will be nice to have such a possibility. Now it is barely possible with class_alias() or maybe different workaround.

Just want to know your opinion, for now.

@JanTvrdik
Copy link
Contributor

Why problem are you trying to solve?

@bacinsky
Copy link
Author

I think the DI solves both issues, disabling the Tracy Bar and even its customization. Injecting the BlueScreen object will be nice too. Tracy is for developers, it should be. Maybe time to introduce interfaces for some interchangeable parts?

@bacinsky bacinsky changed the title Add support for Bar and BlueScreen Debugger dependency injection [RFC] Add support for Bar and BlueScreen Debugger dependency injection Nov 24, 2014
@JanTvrdik
Copy link
Contributor

I hate when people use RFC without doing anything that would classify as RFC (evaluating of current situation and explaining what is wrong with it, proposing a solution and explaining why it should be accepted, what is the impact on backward compatibility etc.) Maybe we should stop using the RFC word at all.

@bacinsky
Copy link
Author

My bad, but I'm trying to get some attention on this issue before I put more effort to and it works. I'll try to get some time on learning how to write a RFC, you can close this, if you want. I can handle it.

@fprochazka
Copy link
Contributor

@bacinsky more appropriate would to remove the word from the issue title.

@hrach hrach changed the title [RFC] Add support for Bar and BlueScreen Debugger dependency injection Add support for Bar and BlueScreen Debugger dependency injection Nov 24, 2014
@JanTvrdik
Copy link
Contributor

I still don't know what are you trying to solve. What do you need to customize? How would you solve #82 with this?

@dg
Copy link
Member

dg commented Nov 25, 2014

I wonder why there is no way to set Tracy\Bar and Tracy\BlueScreen into Tracy\Debugger via setter

Simply nobody needs it. And things that nobody needs, I am not implementing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants