Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make the error handler context argument optional #264

Merged
merged 2 commits into from Oct 6, 2017
Merged

Conversation

@xabbuh
Copy link
Contributor

xabbuh commented Oct 6, 2017

The context argument of an error handler is optional. Furthermore, it will be deprecated in PHP 7.2 (see http://www.php.net/manual/en/function.set-error-handler.php).

  • bug fix? yes
  • new feature? no
  • BC break? no
  • doc PR: -
The context argument of an error handler is optional. Furthermore, it will be deprecated in PHP 7.2 (see http://www.php.net/manual/en/function.set-error-handler.php).
@@ -361,7 +361,7 @@ public static function exceptionHandler($exception, $exit = true)
* @throws ErrorException
* @internal
*/
public static function errorHandler($severity, $message, $file, $line, $context)
public static function errorHandler($severity, $message, $file, $line, $context = array())

This comment has been minimized.

Copy link
@dg

dg Oct 6, 2017

Member

Please change array() to []

This comment has been minimized.

Copy link
@xabbuh

xabbuh Oct 6, 2017

Author Contributor

done

@dg dg merged commit 7b4b8f5 into nette:master Oct 6, 2017
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@dg

This comment has been minimized.

Copy link
Member

dg commented Oct 6, 2017

Thanks!

@xabbuh xabbuh deleted the xabbuh:patch-1 branch Oct 6, 2017
@xabbuh

This comment has been minimized.

Copy link
Contributor Author

xabbuh commented Oct 6, 2017

Thanks for merging!

@mvrhov mvrhov mentioned this pull request Jan 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.