info.panel.html: fix undefined property in list of composer packages #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Field `source` is not mandatory. For example, my local repositories mirrored from a path do not have the field in `composer.lock`. Refs to `source` and `dist` are the same on all my dependencies and even in file `Locker.php` of `composer/composer` package there is the retrieval of reference ID fall-backed by using `dist` field. https://github.com/composer/composer/blob/28e41d094e78e0a60dc5123ee572701154008848/src/Composer/Package/Locker.php#L417
|
Thanks |
dg
pushed a commit
that referenced
this pull request
Apr 3, 2018
…287) Field `source` is not mandatory. For example, my local repositories mirrored from a path do not have the field in `composer.lock`. Refs to `source` and `dist` are the same on all my dependencies and even in file `Locker.php` of `composer/composer` package there is the retrieval of reference ID fall-backed by using `dist` field. https://github.com/composer/composer/blob/28e41d094e78e0a60dc5123ee572701154008848/src/Composer/Package/Locker.php#L417
dg
pushed a commit
that referenced
this pull request
Apr 6, 2018
…287) Field `source` is not mandatory. For example, my local repositories mirrored from a path do not have the field in `composer.lock`. Refs to `source` and `dist` are the same on all my dependencies and even in file `Locker.php` of `composer/composer` package there is the retrieval of reference ID fall-backed by using `dist` field. https://github.com/composer/composer/blob/28e41d094e78e0a60dc5123ee572701154008848/src/Composer/Package/Locker.php#L417
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Field
sourceis not mandatory. For example, my local repositoriesmirrored from a path do not have the field in
composer.lock. Refsto
sourceanddistare the same on all my dependencies and evenin file
Locker.phpofcomposer/composerpackage there is theretrieval of reference ID fall-backed by using
distfield.https://github.com/composer/composer/blob/28e41d094e78e0a60dc5123ee572701154008848/src/Composer/Package/Locker.php#L417