Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

info.panel.html: fix undefined property in list of composer packages #287

Merged
merged 1 commit into from Mar 30, 2018

Conversation

vlastavesely
Copy link
Contributor

@vlastavesely vlastavesely commented Mar 30, 2018

  • bug fix? yes
  • BC break? no

Field source is not mandatory. For example, my local repositories
mirrored from a path do not have the field in composer.lock. Refs
to source and dist are the same on all my dependencies and even
in file Locker.php of composer/composer package there is the
retrieval of reference ID fall-backed by using dist field.

https://github.com/composer/composer/blob/28e41d094e78e0a60dc5123ee572701154008848/src/Composer/Package/Locker.php#L417

Field `source` is not mandatory. For example, my local repositories
mirrored from a path do not have the field in `composer.lock`. Refs
to `source` and `dist` are the same on all my dependencies and even
in file `Locker.php` of `composer/composer` package there is the
retrieval of reference ID fall-backed by using `dist` field.

https://github.com/composer/composer/blob/28e41d094e78e0a60dc5123ee572701154008848/src/Composer/Package/Locker.php#L417
@dg
Copy link
Member

@dg dg commented Mar 30, 2018

Thanks

@dg dg merged commit 9c46d3b into nette:master Mar 30, 2018
1 of 2 checks passed
@vlastavesely vlastavesely deleted the composer-fix branch Mar 30, 2018
dg pushed a commit that referenced this issue Apr 3, 2018
…287)

Field `source` is not mandatory. For example, my local repositories
mirrored from a path do not have the field in `composer.lock`. Refs
to `source` and `dist` are the same on all my dependencies and even
in file `Locker.php` of `composer/composer` package there is the
retrieval of reference ID fall-backed by using `dist` field.

https://github.com/composer/composer/blob/28e41d094e78e0a60dc5123ee572701154008848/src/Composer/Package/Locker.php#L417
dg pushed a commit that referenced this issue Apr 6, 2018
…287)

Field `source` is not mandatory. For example, my local repositories
mirrored from a path do not have the field in `composer.lock`. Refs
to `source` and `dist` are the same on all my dependencies and even
in file `Locker.php` of `composer/composer` package there is the
retrieval of reference ID fall-backed by using `dist` field.

https://github.com/composer/composer/blob/28e41d094e78e0a60dc5123ee572701154008848/src/Composer/Package/Locker.php#L417
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants