Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first version support nette mailer for send tracy mail #299

Closed
wants to merge 1 commit into from

Conversation

geniv
Copy link
Contributor

@geniv geniv commented May 14, 2018

prepare to mailer support for send

@dg
Copy link
Member

@dg dg commented May 14, 2018

Thanks!

dg pushed a commit that referenced this issue May 16, 2018
@dg dg force-pushed the master branch 2 times, most recently from 9cfa3aa to e3a251b Compare May 16, 2018
@dg dg closed this May 16, 2018
@f3l1x
Copy link
Member

@f3l1x f3l1x commented May 16, 2018

@dg Should not be the mailer optional? What if you don't have it in your app?

@dg
Copy link
Member

@dg dg commented May 16, 2018

You must enable it via option 'netteMailer' in config.

@geniv
Copy link
Contributor Author

@geniv geniv commented May 16, 2018

@dg @f3l1x this resolve setter setMailer(IMaliler)

@@ -56,7 +56,8 @@ public function loadConfiguration()

$builder->addDefinition($this->prefix('logger'))
->setClass('Tracy\ILogger')
->setFactory('Tracy\Debugger::getLogger');
->setFactory('Tracy\Debugger::getLogger')
->addSetup('setMailer', [$builder->getDefinition('mail.mailer')]);
Copy link
Member

@f3l1x f3l1x May 16, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dg Where is the option netteMailer? :-)

Copy link
Contributor Author

@geniv geniv May 16, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@f3l1x oh, ofcourse, in tracy extension missing setting to other mail system...

@f3l1x
Copy link
Member

@f3l1x f3l1x commented May 16, 2018

I am maybe stupid, but setMailer has required argument IMailer. There's no netteMailer options in extension's defaults. It looks like it force you to have IMailer registered in services, otherwise there'll be uncomplete dependency. Don't be?

@dg
Copy link
Member

@dg dg commented May 16, 2018

I did not merge this PR as it was. Merged was 48118da

@f3l1x
Copy link
Member

@f3l1x f3l1x commented May 16, 2018

I see. That's it ;-) Thank you.

@geniv
Copy link
Contributor Author

@geniv geniv commented May 16, 2018

Nice! 👍

dg pushed a commit that referenced this issue May 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants