Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first version support nette mailer for send tracy mail #299

Closed
wants to merge 1 commit into from

Conversation

@geniv
Copy link
Contributor

geniv commented May 14, 2018

prepare to mailer support for send

@dg

This comment has been minimized.

Copy link
Member

dg commented May 14, 2018

Thanks!

dg added a commit that referenced this pull request May 16, 2018
…ls Nette mailer [Closes #299]
@dg dg force-pushed the nette:master branch 2 times, most recently from 9cfa3aa to e3a251b May 16, 2018
@dg dg closed this May 16, 2018
@f3l1x

This comment has been minimized.

Copy link
Member

f3l1x commented May 16, 2018

@dg Should not be the mailer optional? What if you don't have it in your app?

@dg

This comment has been minimized.

Copy link
Member

dg commented May 16, 2018

You must enable it via option 'netteMailer' in config.

@geniv

This comment has been minimized.

Copy link
Contributor Author

geniv commented May 16, 2018

@dg @f3l1x this resolve setter setMailer(IMaliler)

@@ -56,7 +56,8 @@ public function loadConfiguration()

$builder->addDefinition($this->prefix('logger'))
->setClass('Tracy\ILogger')
->setFactory('Tracy\Debugger::getLogger');
->setFactory('Tracy\Debugger::getLogger')
->addSetup('setMailer', [$builder->getDefinition('mail.mailer')]);

This comment has been minimized.

Copy link
@f3l1x

f3l1x May 16, 2018

Member

@dg Where is the option netteMailer? :-)

This comment has been minimized.

Copy link
@geniv

geniv May 16, 2018

Author Contributor

@f3l1x oh, ofcourse, in tracy extension missing setting to other mail system...

@f3l1x

This comment has been minimized.

Copy link
Member

f3l1x commented May 16, 2018

I am maybe stupid, but setMailer has required argument IMailer. There's no netteMailer options in extension's defaults. It looks like it force you to have IMailer registered in services, otherwise there'll be uncomplete dependency. Don't be?

@dg

This comment has been minimized.

Copy link
Member

dg commented May 16, 2018

I did not merge this PR as it was. Merged was 48118da

@f3l1x

This comment has been minimized.

Copy link
Member

f3l1x commented May 16, 2018

I see. That's it ;-) Thank you.

@geniv

This comment has been minimized.

Copy link
Contributor Author

geniv commented May 16, 2018

Nice! 👍

dg added a commit that referenced this pull request May 17, 2018
…ls Nette mailer [Closes #299]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.