first version support nette mailer for send tracy mail #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
dg
force-pushed
the
master
branch
2 times, most recently
from
9cfa3aa
to
e3a251b
Compare
|
@dg Should not be the mailer optional? What if you don't have it in your app? |
|
You must enable it via option 'netteMailer' in config. |
f3l1x
reviewed
May 16, 2018
| @@ -56,7 +56,8 @@ public function loadConfiguration() | |||
|
|
|||
| $builder->addDefinition($this->prefix('logger')) | |||
| ->setClass('Tracy\ILogger') | |||
| ->setFactory('Tracy\Debugger::getLogger'); | |||
| ->setFactory('Tracy\Debugger::getLogger') | |||
| ->addSetup('setMailer', [$builder->getDefinition('mail.mailer')]); | |||
|
I am maybe stupid, but |
|
I did not merge this PR as it was. Merged was 48118da |
|
I see. That's it ;-) Thank you. |
|
Nice! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prepare to mailer support for send