BlueScreen: used scrubber for HTTP headers #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two sections of BlueScreen were previously not properly scrubbed: - HTTP Reqeust / Headers - CLI Request / Arguments This fixes the issue.
|
Would you like me to create a second PR for the 2.x branch? |
|
Thanks. I'll copy it to the 2.7 branch. |
dg
changed the title
dg
pushed a commit
that referenced
this pull request
Jul 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two sections of BlueScreen were previously not properly scrubbed:
This includes, for example, the
Cookieheader, which can easily be used to hijack the session:The Cookie is plaintext-legible in the
Headerssection, while the$_COOKIEsection right below gets properly scrubbed:This PR fixes the issue.