enable custom error template #85
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
forrest79
commented
Nov 28, 2014
forrest79
commented
- feature
- issues - Enable custom error template #84
- documentation - not needed
- BC break - no
|
👍 |
|
This is actually a quite nice solution. |
|
👍, but 👎 on implementation (see my comment). |
| @@ -92,6 +92,9 @@ class Debugger | |||
| /** @var string command to open browser (use 'start ""' in Windows) */ | |||
| public static $browser; | |||
|
|
|||
| /** @var string custom static error template */ | |||
| public static $errorTemplate; | |||
There was a problem hiding this comment.
Why don't you make this default to __DIR__ . '/templates/error.phtml'?
Edit: Ah I see, it's only 5.6+ feature. Fuck PHP...
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.