Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tokenizer is not suggestion but a must #187

Closed
szepeviktor opened this issue Mar 26, 2019 · 7 comments
Closed

Tokenizer is not suggestion but a must #187

szepeviktor opened this issue Mar 26, 2019 · 7 comments

Comments

@szepeviktor
Copy link

@szepeviktor szepeviktor commented Mar 26, 2019

"ext-tokenizer": "to use token_get_all()"

What are your views on declaring tokenizer in "require"?

@szepeviktor

This comment has been minimized.

Copy link
Author

@szepeviktor szepeviktor commented Mar 26, 2019

It is not a built-in extension but in tokenizer.so. See php -n -m

@ktomk

This comment has been minimized.

Copy link

@ktomk ktomk commented Oct 29, 2019

Why is this only in suggest? This package gives fatal errors if the extension is not loaded.

@f3l1x

This comment has been minimized.

Copy link
Member

@f3l1x f3l1x commented Oct 29, 2019

@ktomk Like I get it, it's only suggested because not all classes need tokenizer.

@szepeviktor

This comment has been minimized.

Copy link
Author

@szepeviktor szepeviktor commented Oct 29, 2019

In your project you can add ext-tokenizer as a dependency.

@ktomk

This comment has been minimized.

Copy link

@ktomk ktomk commented Oct 30, 2019

I guess adding it in the project is viable in the case at hand but if this would have taken care in this project, this would have been easier and I'm also a bit curious.

@dg

This comment has been minimized.

Copy link
Member

@dg dg commented Oct 30, 2019

This is simply not required dependency because you are not required to use Nette\Utils\Reflection::getUseStatements()

I think nobody except me uses it :)

@ktomk

This comment has been minimized.

Copy link

@ktomk ktomk commented Oct 30, 2019

Okay, you can add me to the list :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.