Used native PHP function for image types #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Used `image_type_to_extension` and `image_type_to_mime_type`
|
image_type_to_extension() returns jpeg or jpg? Will it work with imagecreatefromjpeg()? |
|
Yes and yes. Didn't find a way to get only jpg from this function. |
dg
force-pushed
the
master
branch
3 times, most recently
from
b7cd30e
to
3e2c4ed
Compare
|
Here you can see it's returning "jpeg" from php 5.6.0 to 7.2.4. |
|
ok, thanks |
dg
pushed a commit
that referenced
this pull request
Apr 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used
image_type_to_extensionandimage_type_to_mime_typeI think it's better to use native functions instead of work with arrays.
http://php.net/manual/en/function.image-type-to-mime-type.php
http://php.net/manual/en/function.image-type-to-extension.php