Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inlining depth effects on indexOf #10964

Open
franz1981 opened this issue Jan 26, 2021 · 0 comments
Open

inlining depth effects on indexOf #10964

franz1981 opened this issue Jan 26, 2021 · 0 comments

Comments

@franz1981
Copy link
Contributor

#10737 has introduced a smarter way to search for a byte into an array stream, but similarly to other methods on ByteBuf it can still get some megamorphic behaviour (due to the ByteBuf hierarchy) or can just fail to inline whatever PlatformDependent method used to access the underline memory, due to call stack depth.

#10368 has improved such behaviour that depends on the inlining strategy used by the OpenJDK (maybe Graal or OpenJ9 behave differently) at the cost of duplicating some code: I'm leaving this issue here if anyone is interested to investigate the impact when indexOf is used in the Netty codebase itself (for Stomp?) ie in a more controlled env.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant