Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

builder for EmbeddedChannel #13358

Open
Bue-von-hon opened this issue Apr 24, 2023 · 0 comments
Open

builder for EmbeddedChannel #13358

Bue-von-hon opened this issue Apr 24, 2023 · 0 comments

Comments

@Bue-von-hon
Copy link

If we provide a builder instead of a constructor, it's easier to implement feature need to add parameters.
If you are ok, I'll create a PR and send it to you. 馃槃

target file https://github.com/netty/netty/blob/4.1/transport/src/main/java/io/netty/channel/embedded/EmbeddedChannel.java

Expected behavior

var channel = EmbeddedChannel.Builder()
                                        .setChannelId(...)
                                        .setHasDisconnect(...)
                                        .build();
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant