Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

networked-hand-controls issues with aframe-v1.5.0 #450

Closed
bruce90j opened this issue Jan 20, 2024 · 2 comments
Closed

networked-hand-controls issues with aframe-v1.5.0 #450

bruce90j opened this issue Jan 20, 2024 · 2 comments

Comments

@bruce90j
Copy link
Contributor

bruce90j commented Jan 20, 2024

The networked-hand-controls component doesn't work properly with aframe-v1.5.0:

  1. Hand color is not updated (example: networked-hand-controls="hand:left;color:gold;").
    To make it work replace:

    const handMaterial = newMesh.children[1].material;
    handMaterial.color = new THREE.Color(this.data.color);

    with:

    const handColor = this.data.color;
    newMesh.traverse(function (object) {
        if (!object.isMesh) { return; }
        object.material.color = new THREE.Color(handColor);
    });
    
  2. Hand controller does not work if controllerComponent is not specified (example: networked-hand-controls="hand:right;handModelStyle:controller;").
    Remove 'gearvr-controls', 'daydream-controls' from the controllerComponents list:

    controllerComponents: [
    'magicleap-controls',
    'vive-controls',
    'oculus-touch-controls',
    'windows-motion-controls',
    'hp-mixed-reality-controls',
    // these were missing from the original hand-controls component:
    'valve-index-controls',
    // some older models that it doesn't hurt to include:
    'oculus-go-controls',
    'gearvr-controls',
    'daydream-controls',
    'vive-focus-controls',
    ],

@vincentfretin
Copy link
Member

Can you please create a PR?

@vincentfretin
Copy link
Member

PR is #451

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants