fix networked-hand-controls issues with aframe-v1.5.0 #451
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The networked-hand-controls component doesn't work properly with aframe-v1.5.0:
Hand color is not updated (example:
networked-hand-controls="hand:left;color:gold;"
).To make it work replace:
networked-aframe/src/components/networked-hand-controls.js
Lines 219 to 220 in 0f84523
with:
Hand controller does not work if controllerComponent is not specified (example:
networked-hand-controls="hand:right;handModelStyle:controller;"
).Remove
'gearvr-controls', 'daydream-controls'
from thecontrollerComponents
list:networked-aframe/src/components/networked-hand-controls.js
Lines 235 to 249 in 0f84523