Fix audio spatialization and expose panner properties #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Audio spatialization was screwed up because in addition to hearing the spatialized audio you could also hear audio coming from the Audio element used to fix the MediaStreamAduioSourceNode in Chrome. This mutes the secondary audio playback. (Ideally we can figure out a different workaround for fixing Chrome altogether).
Also, since aframevr/aframe#3042 got closed, I just went ahead and exposed the rest of the
PannerNodeproperties thatTHREE.PositionalAudioexposes.For full positional audio support the properties related to orientation (
coneInnerAngle,coneOuterAngle, andconeOuterGain) should also be exposed, but this requires an update toTHREE.PositionalAudioto expose these properties and update thePannerNode's orientation, so I will leave that as an additional exercise.