Fix the a-saturday-night example with latest aframe #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentfretin
force-pushed
the
fix-a-saturday-night
branch
from
4d5b371
to
490df12
Compare
|
The latest commits from https://github.com/aframevr/a-saturday-night are from 2017. The gtlf models there are the same, gltf 1.0, not 2.0. There are the blend files in the repo, but I can't open them with blender 2.92.0 and 2.83.x or 2.79b on ubuntu, blender just crashes with an error about DNA block. The a-saturday-night original repo runs on aframe 0.6.1 was the last version where you could load gtlf 1.0. I'll just remove this example from the repo I guess. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is half fixed, may need to retrieve new assets from https://aframe.io/a-saturday-night/
https://github.com/aframevr/a-saturday-night
This closes #239