check for empty occupants fixed #264
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For me that check always returned false and the room never got cleaned up properly
| @@ -76,7 +76,7 @@ io.on("connection", socket => { | |||
| const occupants = rooms[curRoom].occupants; | |||
| socket.to(curRoom).broadcast.emit("occupantsChanged", { occupants }); | |||
|
|
|||
| if (occupants == {}) { | |||
| if (JSON.stringify(occupants) === JSON.stringify({})) { | |||
There was a problem hiding this comment.
You're right
occupants={}
occupants == {}
false
Instead of jsonify to do a comparison.
if (Object.keys(occupants).length === 0)
should be better, this is what open-easyrtc more or less do via the underscore size function.
Can you please test that and tell me if it's good for you?
There was a problem hiding this comment.
if (Object.keys(occupants).length === 0)
works as well
|
Thank you for the contribution! If you can test the change I proposed and update the PR, it would be great. |
vincentfretin
added a commit
that referenced
this pull request
Mar 25, 2021
|
Thanks I fixed it in 6606e14 |
vincentfretin
added a commit
that referenced
this pull request
Mar 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For me that check always returned false and the room never got cleaned up properly