Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to aframe 1.3.0 #313

Merged
merged 6 commits into from Feb 12, 2022
Merged

Update to aframe 1.3.0 #313

merged 6 commits into from Feb 12, 2022

Conversation

vincentfretin
Copy link
Member

Update to aframe 1.3.0 and latest buffer-interpolation version #280

Issues you may encounter when upgrading your project to aframe 1.3.0:

  • If your model appears darker than with aframe 1.2.0, try adding renderer="colorManagement: true" to <a-scene>
  • If you use the environment component and it appears broken, be sure to update it to version 1.3.1.

@vincentfretin
Copy link
Member Author

I see some warnings
THREE.Quaternion: Static .slerp() has been deprecated. Use qm.slerpQuaternions( qa, qb, t ) instead.
in the shooter and google blocks examples. Not sure where those come from. Someone has an idea?

@vincentfretin
Copy link
Member Author

vincentfretin commented Feb 12, 2022

I see the stacktrace of the warning now, on Chrome. I was testing with Firefox last time I think and didn't see it.
I have the warning when there is a second participant. With npm run dev

THREE.Quaternion: Static .slerp() has been deprecated. Use qm.slerpQuaternions( qa, qb, t ) instead.
slerp @ three.js:2618
slerp @ buffered-interpolation.js:106
update @ buffered-interpolation.js:213
tick @ networked.js:288

wait..., executing npm start fixed the issue. npm start is doing a build a copy it to examples/dist/
but npm run dev seemed to use an old build instead of rebuilding it in memory. If I remove the files examples/dist/ and run npm run dev, this is properly working, the build is done in memory.
Ok, there is probably something I don't understand about webpack, or a misconfiguration? Bah nevermind. Let's merge this.

@vincentfretin vincentfretin merged commit 4eb4014 into master Feb 12, 2022
@vincentfretin vincentfretin deleted the update-aframe-1.3.0 branch February 12, 2022 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant