Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update socket.io to 2.5.0 to fix engine.io vulnerability #351

Merged
merged 2 commits into from Jul 21, 2022

Conversation

vincentfretin
Copy link
Member

@vincentfretin vincentfretin commented Jul 21, 2022

See 2.5.0 release notes and security advisory at
https://github.com/socketio/socket.io/releases/tag/2.5.0

A new networked-aframe release is not needed, but you need to double check the socket.io version you use in your own projects. On glitch, open the terminal and execute the following:

rm -rf package-lock.json node_modules/*
refresh

and wait a few seconds, it will automatically do the npm install getting the latest versions. (You can open the Logs tab to see that)
Note that on glitch node_modules is a symlink to a volume. If you do rm -rf package-lock.json node_modules (without the star), it won't remove the currently installed packages, and npm install will still use the old socket.io version.

and for client side, in index.html, use

<script src="https://cdnjs.cloudflare.com/ajax/libs/socket.io/2.5.0/socket.io.slim.js"></script>

The naf-project glitch template has been updated.

@vincentfretin vincentfretin merged commit 25ff657 into master Jul 21, 2022
@vincentfretin vincentfretin deleted the update-socketio branch July 21, 2022 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant