Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conflicting button style in aframe inspector #353

Merged
merged 1 commit into from Jul 28, 2022

Conversation

vincentfretin
Copy link
Member

The issue was this, aframe inspector is using the button class on the inspector buttons, conflicting with the css rule we have in style.css
Capture d’écran de 2022-07-28 13-20-29

To fix the issue I modified the css rule to target the buttons in the actions div.
If you have some examples that is using the style.css and the button class, be sure to put the buttons in a div with class actions. All the examples are using this construct since #302

<div class="actions">                                                       
  <button id="camera-btn" type="button" class="button">Hide Camera</button> 
</div>

@vincentfretin vincentfretin merged commit 53e0c0e into master Jul 28, 2022
@vincentfretin vincentfretin deleted the fix-style-in-inspector branch July 28, 2022 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant