-
Notifications
You must be signed in to change notification settings - Fork 317
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
Co-authored-by: Matti Hansson <matti.hansson@lm.se>
- Loading branch information
Showing
5 changed files
with
262 additions
and
15 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,189 @@ | ||
| /* | ||
| * Copyright (c) 2020 Network New Technologies Inc. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package com.networknt.schema; | ||
|
|
||
| import com.fasterxml.jackson.databind.JsonNode; | ||
| import io.undertow.Undertow; | ||
| import io.undertow.server.handlers.resource.FileResourceManager; | ||
| import org.junit.jupiter.api.BeforeEach; | ||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| import java.io.File; | ||
| import java.net.URI; | ||
|
|
||
| import static io.undertow.Handlers.resource; | ||
| import static org.junit.jupiter.api.Assertions.*; | ||
|
|
||
| public class Issue619Test extends BaseJsonSchemaValidatorTest { | ||
|
|
||
| private JsonSchemaFactory factory; | ||
| private JsonNode one; | ||
| private JsonNode two; | ||
| private JsonNode three; | ||
|
|
||
| @BeforeEach | ||
| public void setup() throws Exception { | ||
| factory = JsonSchemaFactory.getInstance(SpecVersion.VersionFlag.V4); | ||
| one = getJsonNodeFromStringContent("1"); | ||
| two = getJsonNodeFromStringContent("2"); | ||
| three = getJsonNodeFromStringContent("3"); | ||
| } | ||
|
|
||
| @Test | ||
| public void bundledSchemaLoadsAndValidatesCorrectly_Ref() { | ||
| JsonSchema referencingRootSchema = factory.getSchema("{ \"$ref\": \"resource:schema/issue619.json\" }"); | ||
|
|
||
| assertTrue(referencingRootSchema.validate(one).isEmpty()); | ||
| assertTrue(referencingRootSchema.validate(two).isEmpty()); | ||
| assertFalse(referencingRootSchema.validate(three).isEmpty()); | ||
| } | ||
|
|
||
| @Test | ||
| public void bundledSchemaLoadsAndValidatesCorrectly_Uri() throws Exception { | ||
| JsonSchema rootSchema = factory.getSchema(new URI("resource:schema/issue619.json")); | ||
|
|
||
| assertTrue(rootSchema.validate(one).isEmpty()); | ||
| assertTrue(rootSchema.validate(two).isEmpty()); | ||
| assertFalse(rootSchema.validate(three).isEmpty()); | ||
| } | ||
|
|
||
| @Test | ||
| public void uriWithEmptyFragment_Ref() { | ||
| JsonSchema referencingRootSchema = factory.getSchema("{ \"$ref\": \"resource:schema/issue619.json#\" }"); | ||
|
|
||
| assertTrue(referencingRootSchema.validate(one).isEmpty()); | ||
| assertTrue(referencingRootSchema.validate(two).isEmpty()); | ||
| assertFalse(referencingRootSchema.validate(three).isEmpty()); | ||
| } | ||
|
|
||
| @Test | ||
| public void uriWithEmptyFragment_Uri() throws Exception { | ||
| JsonSchema rootSchema = factory.getSchema(new URI("resource:schema/issue619.json#")); | ||
|
|
||
| assertTrue(rootSchema.validate(one).isEmpty()); | ||
| assertTrue(rootSchema.validate(two).isEmpty()); | ||
| assertFalse(rootSchema.validate(three).isEmpty()); | ||
| } | ||
|
|
||
| @Test | ||
| public void uriThatPointsToTwoShouldOnlyValidateTwo_Ref() { | ||
| JsonSchema referencingTwoSchema = factory.getSchema("{ \"$ref\": \"resource:schema/issue619.json#/definitions/two\" }"); | ||
|
|
||
| assertFalse(referencingTwoSchema.validate(one).isEmpty()); | ||
| assertTrue(referencingTwoSchema.validate(two).isEmpty()); | ||
| assertFalse(referencingTwoSchema.validate(three).isEmpty()); | ||
| } | ||
|
|
||
| @Test | ||
| public void uriThatPointsToOneShouldOnlyValidateOne_Uri() throws Exception { | ||
| JsonSchema oneSchema = factory.getSchema(new URI("resource:schema/issue619.json#/definitions/one")); | ||
|
|
||
| assertTrue(oneSchema.validate(one).isEmpty()); | ||
| assertFalse(oneSchema.validate(two).isEmpty()); | ||
| assertFalse(oneSchema.validate(three).isEmpty()); | ||
| } | ||
|
|
||
| @Test | ||
| public void uriThatPointsToNodeThatInTurnReferencesOneShouldOnlyValidateOne_Ref() { | ||
| JsonSchema referencingTwoSchema = factory.getSchema("{ \"$ref\": \"resource:schema/issue619.json#/definitions/refToOne\" }"); | ||
|
|
||
| assertTrue(referencingTwoSchema.validate(one).isEmpty()); | ||
| assertFalse(referencingTwoSchema.validate(two).isEmpty()); | ||
| assertFalse(referencingTwoSchema.validate(three).isEmpty()); | ||
| } | ||
|
|
||
| @Test | ||
| public void uriThatPointsToNodeThatInTurnReferencesOneShouldOnlyValidateOne_Uri() throws Exception { | ||
| JsonSchema oneSchema = factory.getSchema(new URI("resource:schema/issue619.json#/definitions/refToOne")); | ||
|
|
||
| assertTrue(oneSchema.validate(one).isEmpty()); | ||
| assertFalse(oneSchema.validate(two).isEmpty()); | ||
| assertFalse(oneSchema.validate(three).isEmpty()); | ||
| } | ||
|
|
||
| @Test | ||
| public void uriThatPointsToSchemaWithIdThatHasDifferentUri_Ref() throws Exception { | ||
| runLocalServer(() -> { | ||
| JsonNode oneArray = getJsonNodeFromStringContent("[[1]]"); | ||
| JsonNode textArray = getJsonNodeFromStringContent("[[\"a\"]]"); | ||
|
|
||
| JsonSchema schemaWithIdFromRef = factory.getSchema("{ \"$ref\": \"resource:draft4/refRemote.json#/3/schema\" }"); | ||
| assertTrue(schemaWithIdFromRef.validate(oneArray).isEmpty()); | ||
| assertFalse(schemaWithIdFromRef.validate(textArray).isEmpty()); | ||
| }); | ||
| } | ||
|
|
||
| @Test | ||
| public void uriThatPointsToSchemaWithIdThatHasDifferentUri_Uri() throws Exception { | ||
| runLocalServer(() -> { | ||
| JsonNode oneArray = getJsonNodeFromStringContent("[[1]]"); | ||
| JsonNode textArray = getJsonNodeFromStringContent("[[\"a\"]]"); | ||
|
|
||
| JsonSchema schemaWithIdFromUri = factory.getSchema(new URI("resource:draft4/refRemote.json#/3/schema")); | ||
| assertTrue(schemaWithIdFromUri.validate(oneArray).isEmpty()); | ||
| assertFalse(schemaWithIdFromUri.validate(textArray).isEmpty()); | ||
| }); | ||
| } | ||
|
|
||
| private interface ThrowingRunnable { | ||
| void run() throws Exception; | ||
| } | ||
|
|
||
| private void runLocalServer(ThrowingRunnable actualTest) throws Exception { | ||
| Undertow server = Undertow.builder() | ||
| .addHttpListener(1234, "localhost") | ||
| .setHandler(resource(new FileResourceManager( | ||
| new File("./src/test/resources/remotes"), 100))) | ||
| .build(); | ||
| try { | ||
| server.start(); | ||
|
|
||
| actualTest.run(); | ||
|
|
||
| } finally { | ||
| try { | ||
| Thread.sleep(100); | ||
| } catch (InterruptedException ignored) { | ||
| Thread.currentThread().interrupt(); | ||
| } | ||
| server.stop(); | ||
| } | ||
| } | ||
|
|
||
| @Test | ||
| public void uriThatPointsToSchemaThatDoesNotExistShouldFail_Ref() { | ||
| JsonSchema referencingNonexistentSchema = factory.getSchema("{ \"$ref\": \"resource:data/schema-that-does-not-exist.json#/definitions/something\" }"); | ||
|
|
||
| assertThrows(JsonSchemaException.class, () -> referencingNonexistentSchema.validate(one)); | ||
| } | ||
|
|
||
| @Test | ||
| public void uriThatPointsToSchemaThatDoesNotExistShouldFail_Uri() { | ||
| assertThrows(JsonSchemaException.class, () -> factory.getSchema(new URI("resource:data/schema-that-does-not-exist.json#/definitions/something"))); | ||
| } | ||
|
|
||
| @Test | ||
| public void uriThatPointsToNodeThatDoesNotExistShouldFail_Ref() { | ||
| JsonSchema referencingNonexistentSchema = factory.getSchema("{ \"$ref\": \"resource:schema/issue619.json#/definitions/node-that-does-not-exist\" }"); | ||
|
|
||
| assertThrows(JsonSchemaException.class, () -> referencingNonexistentSchema.validate(one)); | ||
| } | ||
|
|
||
| @Test | ||
| public void uriThatPointsToNodeThatDoesNotExistShouldFail_Uri() { | ||
| assertThrows(JsonSchemaException.class, () -> factory.getSchema(new URI("resource:schema/issue619.json#/definitions/node-that-does-not-exist"))); | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| { | ||
| "$schema": "http://json-schema.org/draft-04/schema#", | ||
| "id": "resource:schema/issue619.json", | ||
| "oneOf": [ | ||
| { | ||
| "$ref": "#/definitions/one" | ||
| }, | ||
| { | ||
| "$ref": "#/definitions/two" | ||
| } | ||
| ], | ||
| "definitions": { | ||
| "one": { | ||
| "type": "integer", | ||
| "enum": [1] | ||
| }, | ||
| "two": { | ||
| "type": "integer", | ||
| "enum": [2] | ||
| }, | ||
| "refToOne": { | ||
| "$ref": "#/definitions/one" | ||
| } | ||
| } | ||
| } |