Fix for https://github.com/networknt/light-rest-4j/issues/64 #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rent request parts
-code clean up from previous commit.
-Implement light-rest-4j networknt#64 for Swagger ValidatorHandler
-clean up a legacy constructor
|
renamed ValidatorConfig to SchemaValidatorsConfig based on comments of networknt/light-rest-4j#65 |
|
Any reason to use plural instead of singular? SchemaValidatorsConfig vs SchemaValidatorConfig. |
Because this config obj is in BaseJsonValidator. Any validator extends this BaseJsonValidator will have this config, so I think this config obj can contain configs not only for TypeValidator but can also have configs for other validators. What do you think? |
|
Good. It is just a name and I am just curious. Thanks. |
stevehu
approved these changes
Dec 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-this PR is part of the fix for networknt/light-rest-4j#64
-BaseValidator will have a new property "ValidatorConfig", this ValidatorConfig will be set when constructing from the constructor, get from ValidationContext. Its child validator "TypeValidator" will use this property to get the config.
-"VaidatorConfig" will be set into "ValidationContext" when creating new JsonSchema using "newJsonSchema()" in "JsonSchemaFactory"