fixes #171 validation of quoted numerics added #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BalloonWen
approved these changes
Jul 19, 2019
stevehu
approved these changes
Jul 20, 2019
|
Version 1.0.17 has been released. Thanks a lot for the excellent collaboration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed solution to issue raised in #171
Testing
Organized tests into sections (positive and negative) tests for
number,integer, andintegerwith exclusive type of behavior.Each collection of inputs is augmented with it's corresponding quoted counter part.
Quoting thresholds does not seem necessary as they can be parsed into numbers at schema creation time.