Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#173 - Do not ignore other errors in case of anyOf validator #176

Merged
merged 1 commit into from
Jul 29, 2019

Conversation

grssam
Copy link
Contributor

@grssam grssam commented Jul 24, 2019

Fixes issue #173
Also added a way to validate the error count in test cases using the optional int field "errorCount"

@grssam
Copy link
Contributor Author

grssam commented Jul 26, 2019

Please let me know if any further changes are required.

@grssam
Copy link
Contributor Author

grssam commented Jul 29, 2019

@stevehu - How long does a review usually take? We are actually waiting for this fix.

@stevehu
Copy link
Contributor

stevehu commented Jul 29, 2019

@grssam A lot of our developers are on vacation these days and things are going very slow. I have reviewed the PR but want another pair of eyes to review it to ensure backward compatibility. The change is very straight forward and I will merge it and publish it now.

@stevehu stevehu merged commit 3b53147 into networknt:master Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants