Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for cross-draft validation #779

Merged
merged 1 commit into from May 22, 2023
Merged

Adds support for cross-draft validation #779

merged 1 commit into from May 22, 2023

Conversation

fdutton
Copy link
Contributor

@fdutton fdutton commented May 21, 2023

Resolves #778

@fdutton fdutton linked an issue May 21, 2023 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

Merging #779 (4bae15f) into master (1834353) will decrease coverage by 0.10%.
The diff coverage is 89.28%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff              @@
##             master     #779      +/-   ##
============================================
- Coverage     75.14%   75.05%   -0.10%     
+ Complexity     1191     1185       -6     
============================================
  Files           122      122              
  Lines          4108     4097      -11     
  Branches        792      787       -5     
============================================
- Hits           3087     3075      -12     
- Misses          696      698       +2     
+ Partials        325      324       -1     
Impacted Files Coverage Δ
...n/java/com/networknt/schema/JsonSchemaFactory.java 78.77% <83.33%> (-0.20%) ⬇️
...rc/main/java/com/networknt/schema/SpecVersion.java 87.50% <92.30%> (-3.41%) ⬇️
...java/com/networknt/schema/SpecVersionDetector.java 100.00% <100.00%> (+4.16%) ⬆️

... and 1 file with indirect coverage changes

@stevehu stevehu merged commit 3cf9bb6 into master May 22, 2023
4 checks passed
@stevehu stevehu deleted the issue778 branch May 22, 2023 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support cross-draft validation
3 participants