Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve vocabulary support #953

Merged
merged 1 commit into from
Feb 6, 2024
Merged

Conversation

justin-tay
Copy link
Contributor

Closes #753

This improves the support for the $vocabulary keyword used in a meta schema.

@codecov-commenter
Copy link

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (51fd82b) 78.98% compared to head (a59ad6d) 78.99%.

Files Patch % Lines
src/main/java/com/networknt/schema/Vocabulary.java 68.75% 10 Missing ⚠️
.../java/com/networknt/schema/UnionTypeValidator.java 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #953   +/-   ##
=========================================
  Coverage     78.98%   78.99%           
- Complexity     1717     1724    +7     
=========================================
  Files           157      158    +1     
  Lines          5715     5750   +35     
  Branches       1079     1086    +7     
=========================================
+ Hits           4514     4542   +28     
- Misses          802      809    +7     
  Partials        399      399           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stevehu stevehu merged commit a61cf42 into networknt:master Feb 6, 2024
4 checks passed
@justin-tay justin-tay deleted the vocab_master branch February 28, 2024 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is the $vocabulary keyword supported?
3 participants