Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ethlo excludable #974

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Make ethlo excludable #974

merged 1 commit into from
Feb 22, 2024

Conversation

justin-tay
Copy link
Contributor

Closes #973

This makes the ethlo dependency excludable. This isn't the same as making it optional as optional dependencies need to be explicitly added, while excludable needs to be explicitly excluded.

@codecov-commenter
Copy link

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (bc93b44) 78.75% compared to head (0519d3f) 78.63%.

Files Patch % Lines
...va/com/networknt/schema/format/DateTimeFormat.java 43.75% 7 Missing and 2 partials ⚠️
.../main/java/com/networknt/schema/utils/Classes.java 40.00% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #974      +/-   ##
============================================
- Coverage     78.75%   78.63%   -0.12%     
- Complexity     1850     1851       +1     
============================================
  Files           164      165       +1     
  Lines          5987     6001      +14     
  Branches       1146     1147       +1     
============================================
+ Hits           4715     4719       +4     
- Misses          837      846       +9     
- Partials        435      436       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stevehu stevehu merged commit 8c2f60b into networknt:master Feb 22, 2024
4 checks passed
@justin-tay justin-tay deleted the ethlo_master branch March 4, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ethlo as an optional dependency?
3 participants