Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Eureka for service discovery #768

Closed
tsuilouis opened this issue Sep 23, 2020 · 4 comments
Closed

Support Eureka for service discovery #768

tsuilouis opened this issue Sep 23, 2020 · 4 comments
Assignees
Labels
enhancement Issue: Enhancement

Comments

@tsuilouis
Copy link

Currently, light-4j has support for Consul and Zookeeper for service discovery. @chenyan71 has stated that the team plans to add a module for Eureka as well. I've expressed interest in taking on this task.

This issue is to track the planning and design of supporting Eureka.

The first step for me should probably be to go through Eureka documentation and figure out how it works at a high level. Then I can look at what pieces are necessary for light-4j to use.

@tsuilouis tsuilouis added the enhancement Issue: Enhancement label Sep 23, 2020
@tsuilouis tsuilouis self-assigned this Sep 23, 2020
@stevehu
Copy link
Contributor

stevehu commented Nov 22, 2020

@tsuilouis @chenyan71 Just FYI. I recently created a Portal Registry to replace Consul as it has some issues. Also, a new module portal-registry is added to the light-4j as another registry/discovery support.

It is a lot simple than Consul and using WebSocket to update instead of Blocking Query(long poll) and it saves a lot of threads for the consumer if there are too many downstream services.

The long term is to move all users to the light-portal registry that is integrated with a lot of other portal services. I am writing some tutorials and will give you guys access once it is ready.

@stevehu
Copy link
Contributor

stevehu commented Mar 22, 2021

@tsuilouis @chenyan71 As our strategy is to attract users to use the light-controller along with the light-router, we should focus our effort on the light-portal instead in my opinion. The eureka project is a very good reference for us to implement the light-controller though. What do you think?

@tsuilouis
Copy link
Author

@stevehu sure, that makes sense. Should I close this issue then? cc @chenyan71

@stevehu
Copy link
Contributor

stevehu commented Mar 23, 2021

@tsuilouis As we've discussed, I am closing it.

@stevehu stevehu closed this as completed Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issue: Enhancement
Projects
None yet
Development

No branches or pull requests

2 participants