Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add startOnRegistryFailure to server.yml to control if start the server after failing to register #845

Closed
stevehu opened this issue Dec 2, 2020 · 1 comment

Comments

@stevehu
Copy link
Contributor

stevehu commented Dec 2, 2020

When we set the enableRegistry flag to true in the server.yml to register the service to the Light-controller or Consul for global registry/discovery, the server will stop if the registry is not reachable.

It is the desired behaviour if we are using the global registry for service discovery. However, in the following scenario, we might want the server to start even if it is failed to register.

In a development environment and the Light-control is deployed as a standalone service without the cluster configuration backed by Kafka Streams. The registration is done on a best-effort basis. The purpose of the registry is to monitor the runtime instances with the health check. And to leverage the additional features like server info access and changing the logging level on an individual instance in a cloud environment.

stevehu added a commit that referenced this issue Dec 2, 2020
@stevehu stevehu closed this as completed in 69363c7 Dec 2, 2020
stevehu added a commit that referenced this issue Dec 2, 2020
younggwon1 pushed a commit to younggwon1/light-4j that referenced this issue Feb 10, 2024
…ol if start the server after failing to register (networknt#846)
younggwon1 pushed a commit to younggwon1/light-4j that referenced this issue Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant