fix NPE in SimpleConnectionPool.restore() and optimize borrow() with computeIfAbsent() #1938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ow() with use of computeIfAbsent()
jaydeepparekh1311
approved these changes
Oct 30, 2023
AkashWorkGit
approved these changes
Oct 31, 2023
stevehu
pushed a commit
that referenced
this pull request
Jan 25, 2024
…ow() with use of computeIfAbsent() (#1938) Co-authored-by: Michael Christoff <mike.christoff@cibc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #1898
We can use the computeIfAbsent method of ConcurrentHashMap to add a new SimpleURIConnectionPool to a SimpleConnectionPool.
computeIfAbsent uses more efficient lock on the hashmap bucket for they uri key, rather than requiring synchronization on the entire ConcurrentHashMap.
Also we avoid creating an then discarding objects if the method is called after a value has already been put, since the lamda argument of computeIfAbsent is only executed if a value does not already exist.
Additionally, there is a missing NP check in the restore method.