Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert upgrades of snakeyaml and jackson until compatibility updates made (1.6.x) #1959

Merged
merged 1 commit into from Nov 5, 2023

Conversation

miklish
Copy link
Collaborator

@miklish miklish commented Nov 5, 2023

Issue: #1958

Recent commits to the light-4j 1.6.x branch have updated snakeyaml to 2.2 and Jackson to 2.15.3.

However, these dependency updates are not compatible with the current light-4j 1.6.x code-base.

Numerous code changes must be made to light-4j code base to make light-4j 1.6.x compatible with these updated dependency versions.

For example, snakeyaml 2.2 has changed numerous previously-zero-argument constructors to constructors that require arguments causing compilation failures. Jackson has deprecated certain TimeZone classes that are causing existing unit tests to fail.

The dependency version updates cannot be made alone without the code changes needed to make the codebase properly work with the changes in snakeyaml 2.2 and Jackson 2.15.3.

See discussions on the need for the downgrades here (snakeyaml):

adc9196#commitcomment-131730044

and here (jackson):

0c83580#commitcomment-131731260

[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  23.921 s
[INFO] Finished at: 2023-11-04T20:36:11-04:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.0:compile (default-compile) on project config: Compilation failure: Compilation failure:
[ERROR] /Users/miklish/localrepo2/CP214-BUILD-ERROR/light-4j/config/src/main/java/com/networknt/config/Config.java:[161,66] error: constructor Representer in class Representer cannot be applied to given types;
[ERROR]   required: DumperOptions
[ERROR]   found: no arguments
[ERROR]   reason: actual and formal argument lists differ in length
[ERROR] /Users/miklish/localrepo2/CP214-BUILD-ERROR/light-4j/config/src/main/java/com/networknt/config/yml/ConfigLoaderConstructor.java:[19,8] error: no suitable constructor found for Constructor(no arguments)
[ERROR]     constructor Constructor.Constructor(LoaderOptions) is not applicable
[ERROR]       (actual and formal argument lists differ in length)
[ERROR]     constructor Constructor.Constructor(Class<? extends Object>,LoaderOptions) is not applicable
[ERROR]       (actual and formal argument lists differ in length)
[ERROR]     constructor Constructor.Constructor(TypeDescription,LoaderOptions) is not applicable
[ERROR]       (actual and formal argument lists differ in length)
[ERROR]     constructor Constructor.Constructor(TypeDescription,Collection<TypeDescription>,LoaderOptions) is not applicable
[ERROR]       (actual and formal argument lists differ in length)
[ERROR]     constructor Constructor.Constructor(String,LoaderOptions) is not applicable
[ERROR]       (actual and formal argument lists differ in length)
[ERROR] /Users/miklish/localrepo2/CP214-BUILD-ERROR/light-4j/config/src/main/java/com/networknt/config/yml/DecryptConstructor.java:[32,2] error: no suitable constructor found for Constructor(no arguments)
[ERROR]     constructor Constructor.Constructor(LoaderOptions) is not applicable
[ERROR]       (actual and formal argument lists differ in length)
[ERROR]     constructor Constructor.Constructor(Class<? extends Object>,LoaderOptions) is not applicable
[ERROR]       (actual and formal argument lists differ in length)
[ERROR]     constructor Constructor.Constructor(TypeDescription,LoaderOptions) is not applicable
[ERROR]       (actual and formal argument lists differ in length)
[ERROR]     constructor Constructor.Constructor(TypeDescription,Collection<TypeDescription>,LoaderOptions) is not applicable
[ERROR]       (actual and formal argument lists differ in length)
[ERROR]     constructor Constructor.Constructor(String,LoaderOptions) is not applicable
[ERROR]       (actual and formal argument lists differ in length)

…ckson from 2.14.0 to 2.15.3 until additonal code changes required for compatibility with these version upgrades have been made
@miklish miklish changed the title revert upgrades of snakeyaml and jackson until compatibility updates made revert upgrades of snakeyaml and jackson until compatibility updates made (1.6.x) Nov 5, 2023
@stevehu
Copy link
Contributor

stevehu commented Nov 5, 2023

I just merged snakeyaml PR. Now the light-4j 1.6.x is built.

@stevehu stevehu merged commit fa288b4 into 1.6.x Nov 5, 2023
stevehu added a commit that referenced this pull request Nov 5, 2023
…de of jackson from 2.14.0 to 2.15.3 until additonal code changes required for compatibility with these version upgrades have been made (#1959)"

This reverts commit fa288b4.
stevehu added a commit that referenced this pull request Nov 5, 2023
…de of jackson from 2.14.0 to 2.15.3 until additonal code changes required for compatibility with these version upgrades have been made (#1959)" (#1960)

This reverts commit fa288b4.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants