Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #332, (API 6) in consul client the wait hard coded value changed through configuration #333

Merged
merged 2 commits into from Dec 13, 2018

Conversation

sreeni1990
Copy link
Contributor

Issue #332, (API 6) in consul client the wait hard coded value changed through configuration.

@stevehu
Copy link
Contributor

stevehu commented Dec 12, 2018

I was considered to make it configurable in the beginning but hard-coded instead. This is the value to controls blocking query timeout for consul. It has a hard limit of 10 minutes and default to 5 minutes. I have decided to use 10 minutes as default as it is the maximum we can use. I am afraid people will put something like 900s and I don't know what would be the behavior of Consul in that case. If we want to make it configurable, I think we need to make more info available in the consul.yml file about this property to ensure that users won't misconfigure this field. Do we have other reasons we want to change this value? For TSO project? Thanks.

@sreeni1990
Copy link
Contributor Author

Added description about that property in consul.yml file.

@whoamnick
Copy link
Member

@stevehu are those comments ok or did you have anything else in mind? I can't remember which projects have asked for this change, but its come up more then once..

@stevehu
Copy link
Contributor

stevehu commented Dec 13, 2018

With the comment in the config file, I think it will be less risky to make any mistakes. I am OK with the change. Thanks.

@whoamnick whoamnick merged commit 2cf8710 into networknt:develop Dec 13, 2018
younggwon1 pushed a commit to younggwon1/light-4j that referenced this pull request Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants