fixes #378 upgrade jsonpath to 2.4.0 and exclude json-smart #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddobrin
approved these changes
Feb 7, 2019
There was a problem hiding this comment.
I'd like to make a suggestion:
- for handler.yml and service.yml, light-codegen can insert a number of handlers, which it comments out as a default
- should we add a chapter in light-doc, related to codegen (https://doc.networknt.com/tool/light-codegen/openapi-generator/) which would explain the list of handlers which are generated and the circumstances under which we wish to enable/disable them?
|
@ddobrin I think it is a good idea to document all the handlers and in which case these handlers will be used. I am just not sure if this should be defined in each individual frameworks or in the light-codegen section in the document site. Or the other options is to write the comments in the handler.yml file in details. |
BalloonWen
approved these changes
Feb 8, 2019
There was a problem hiding this comment.
it looks good to me
related doc to config JsonProvider as reference: https://github.com/json-path/JsonPath#jsonprovider-spi
whoamnick
approved these changes
Feb 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.