Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

514 sanitizer new config properties #563

Merged
merged 16 commits into from Jun 24, 2019

Conversation

jefperito
Copy link
Member

#514
attributesToAppreciate: attributes for apply encoding (ignore everything else)
attributesToIgnore: attributes for ignore encoding (apply everything else)

@stevehu
Copy link
Contributor

stevehu commented Jun 22, 2019

@jefperito I have manually synced the master to the feature branch as the base has been changed from jdk8 to jdk11. One question: why do you name the positive list as attributesToAppreciate instead of attributesToEncode?

@jefperito
Copy link
Member Author

Sure, it's seems a better name to this purpose

@jefperito
Copy link
Member Author

jefperito commented Jun 22, 2019

done, that commit adds an integration test for encoding extended by client as well

@jefperito
Copy link
Member Author

i don't know why that build step is broken:

"No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself."

@stevehu
Copy link
Contributor

stevehu commented Jun 23, 2019

It seems we have some problem with Travis. The local build is OK always and I guess the multiple threads test in client module is not working on Travis as it only allocates one thread per build. There might be other reasons but I don't know. It is nothing to do with this PR.

@stevehu stevehu merged commit ce1a325 into master Jun 24, 2019
@stevehu stevehu deleted the 514-sanitizer-new-config-properties branch June 24, 2019 19:04
younggwon1 pushed a commit to younggwon1/light-4j that referenced this pull request Feb 10, 2024
* networknt#514 adds 2 new properties for sanitizer.yml

* extracts encoding resposability

* creates an encoding strategy defined by encoding property by config

* Adds unit test for Encoder

* Adds list to properties to ignore to encoding values

* Adds id on Encoding interface to self identify

* Adds encoding strategy to enable developers inject yours own encodings

* fixes class name

* add a new list attribute to include attributes to encoding data

* adds tests with 2 parameters

* add integration tests for 2 brand news parameters config

* manually merge from the master branch

* rename attributesToAppreciate to attributesToEncode, add an integration test of encode type.

* moving classes for suitables packages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants