New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
514 sanitizer new config properties #563
Conversation
@jefperito I have manually synced the master to the feature branch as the base has been changed from jdk8 to jdk11. One question: why do you name the positive list as attributesToAppreciate instead of attributesToEncode? |
Sure, it's seems a better name to this purpose |
…on test of encode type.
…ies' into 514-sanitizer-new-config-properties
done, that commit adds an integration test for encoding extended by client as well |
i don't know why that build step is broken: "No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself." |
It seems we have some problem with Travis. The local build is OK always and I guess the multiple threads test in client module is not working on Travis as it only allocates one thread per build. There might be other reasons but I don't know. It is nothing to do with this PR. |
* networknt#514 adds 2 new properties for sanitizer.yml * extracts encoding resposability * creates an encoding strategy defined by encoding property by config * Adds unit test for Encoder * Adds list to properties to ignore to encoding values * Adds id on Encoding interface to self identify * Adds encoding strategy to enable developers inject yours own encodings * fixes class name * add a new list attribute to include attributes to encoding data * adds tests with 2 parameters * add integration tests for 2 brand news parameters config * manually merge from the master branch * rename attributesToAppreciate to attributesToEncode, add an integration test of encode type. * moving classes for suitables packages
#514
attributesToAppreciate: attributes for apply encoding (ignore everything else)
attributesToIgnore: attributes for ignore encoding (apply everything else)