Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make valueMap to be static to prevent multiple warning #628

Merged
merged 1 commit into from
Dec 4, 2019

Conversation

jiachen1120
Copy link
Contributor

related issue: #627

@codecov-io
Copy link

codecov-io commented Dec 4, 2019

Codecov Report

Merging #628 into 1.6.x will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##              1.6.x     #628      +/-   ##
============================================
- Coverage     50.73%   50.71%   -0.02%     
+ Complexity     1912     1910       -2     
============================================
  Files           258      258              
  Lines         11492    11492              
  Branches       1622     1622              
============================================
- Hits           5830     5828       -2     
  Misses         4975     4975              
- Partials        687      689       +2
Impacted Files Coverage Δ Complexity Δ
...ain/java/com/networknt/config/ConfigInjection.java 74.39% <100%> (ø) 25 <0> (ø) ⬇️
...n/java/com/networknt/client/oauth/OauthHelper.java 36.44% <0%> (-0.61%) 26% <0%> (-2%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc4dda9...c2040d1. Read the comment docs.

Copy link
Contributor

@stevehu stevehu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested with the petstore example and it works perfectly. Thanks

@stevehu stevehu merged commit da757ed into 1.6.x Dec 4, 2019
@stevehu stevehu deleted the fix/627display_warning_message_once branch January 12, 2021 20:53
younggwon1 pushed a commit to younggwon1/light-4j that referenced this pull request Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants