Make SSL private to prevent its usage before it is initialized. #630
Conversation
…ssue #629 for full details.
|
Found another usage of SSL in light-4j (OAuthHelper)… WIll fix and update PR branch |
|
Sorry folks... as mentioned, there are more cases where the variable SSL is used directly that weren't updated... updating now |
|
I think this breaks a lot of existing applications. If we don't do anything, all existing applications should work. |
|
I fixed it so it builds now, but the Audit Handler unit tests are failing. I'm examining why this is. As for breaking existing applications, that is a good thing. The alternative is apps that build but fail when run. |
|
I figured out why some of the unit tests were failing. They use Http2Client.SSL in the test, but do not have any truststores configured. The solution is simply to delete the Http2Client.SSL argument. The problem was that I had replaced the Http2Client.SSL argument with Http2Client.getInstance().getDefaultXnioSSL() which caused the client to look for truststores that were not configured. E.g.: The unit tests were relying on the fact that Http2Client.SSL would be null |
|
Ok, as per our discussion, this change should be reverted, as it causes to many issues in other related repos. We will instead deprecate Http2Client.SSL |
…ssue networknt#629 for full details. (networknt#630)
See issue #629 for full details.