fixes #753 handle text/plain and content type missing in BodyHandler #755
Conversation
There was a problem hiding this comment.
There may still be a problem - I found with the original InfluxDB sender code with no content type fell through to code that actually did not get the inputstream content (rather, it returned null). So I figure, the no-content condition needs to either (a) throw error (content type missing), or, (b) needs to be coded to return the request body... we may want to use the same (new code) for "text/plain" as for when no content type is provided...
Thoughts?
|
In the previous implementation, the BodyHandler will be passed if content-type is empty. In that case, the business handler must parse the body by itself which might be a burden for most users. After the change, we just put the input stream into the exchange and treat it as a binary stream. The business hander can just get the input stream from the exchange and consume it. It is the same process for an unknown content type. |
|
That makes sense, but I think we may want to document that pretty well. |
|
You are right about the documentation. I have updated the BodyHandler doc to reflect the changes. Thanks. |
No description provided.