Fix flaky tests in PortalRegistryTest.java and ConsulRegistryTest.java #857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KellyShao
commented
Dec 9, 2020
portal-registry/src/test/java/com/networknt/portal/registry/PortalRegistryTest.java
Show resolved
Hide resolved
|
@KellyShao Thanks a lot for your help. |
BalloonWen
reviewed
Dec 11, 2020
| // unavailable | ||
| registry.doUnavailable(null); | ||
| Thread.sleep(sleepTime); | ||
| Assert.assertFalse(client.isWorking(serviceid)); |
There was a problem hiding this comment.
where is the serviceid defined?
portal-registry/src/test/java/com/networknt/portal/registry/PortalRegistryTest.java
Show resolved
Hide resolved
younggwon1
pushed a commit
to younggwon1/light-4j
that referenced
this pull request
Feb 10, 2024
networknt#857) * Add unregistry for subAndUnsubService() method * Update PortalRegistryTest.java * Add unregistry & unavailable code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed flaky test that caused by unregistered and unavailabled
registryin classPortalRegistryTest.javaandConsulRegistryTest.java.Issue 1
In both classes, if only run
subAndUnsubService()method beforedoRegisterAndAvailable()ordiscoverService()method, the tests will failed. Take thePortalRegistryTestclass for example, the error msgs are:doRegisterAndAvailable()method:discoverService()method:Root cause: Since the
subAndUnsubService()method is the last one, in the default test order in bothPortalRegistryTest.javaandConsulRegistryTest.java. If we simply run the tests, we cannot find out thesubAndUnsubService()method has unregistered URLs.Solution: Unregistered URLs in the
subAndUnsubService()methodIssue 2
discoverService()method beforedoRegisterAndAvailable()method, the tests will failed. Take thePortalRegistryTestclass for example, the error msg is:Root cause: Since the
discoverService()method is always after thedoRegisterAndAvailable()method, in the default test order in bothPortalRegistryTest.javaandConsulRegistryTest.java. If we simply run the tests, we cannot find out thediscoverService()method has unavailabled service.Solution: Unavailabled service in the
discoverService()methodThe flaky tests are found by running iDFlakies, after fixing the issue, there's no flaky tests in
PortalRegistryTest.javaandConsulRegistryTest.java.