issue-864 seprate logging error status and stack trace #865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
BalloonWen
commented
Dec 14, 2020
BalloonWen
commented
- now logging the status ans stack trace separately
- now will only log the stack trace when TRACE is enabled.
| * @param code error code | ||
| * @param args arguments for error description | ||
| * @param code error code | ||
| * @param args arguments for error description |
There was a problem hiding this comment.
no need for tab here as per javadoc standard
| @@ -72,27 +73,35 @@ default void setExchangeStatus(HttpServerExchange exchange, String code, final O | |||
| * want to bubble up to the caller and eventually to the original caller. | |||
| * | |||
| * @param exchange HttpServerExchange | |||
| * @param status error status | |||
| * @param status error status | |||
There was a problem hiding this comment.
no need for tab here as per javadoc standard
jaswalkiranavtar
approved these changes
Dec 14, 2020
stevehu
approved these changes
Dec 14, 2020
BalloonWen
changed the title
younggwon1
pushed a commit
to younggwon1/light-4j
that referenced
this pull request
Feb 10, 2024
- now logging the status ans stack trace separately - now will only log the stack trace when TRACE is enabled. Co-authored-by: Bolun Wen <bolun.wen@sunlife.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.