Add documentation for dump handler #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whoamnick
reviewed
Dec 11, 2018
content/concern/dump.md
Outdated
| @@ -6,10 +6,142 @@ categories: [concerns] | |||
| keywords: [] | |||
| aliases: [] | |||
| toc: false | |||
| draft: false | |||
| draft: true | |||
content/concern/dump.md
Outdated
|
|
||
| This handler is not suggested to be used on production because it will impact the overall performance. | ||
|
|
||
| The default request/response log will be dump.log config. |
There was a problem hiding this comment.
Or whatever's configured in logback.xml right?
There was a problem hiding this comment.
Yes. It won't be automatically generated in logback.xml, so there is not "default" thing. User needs to add it manually. BTW, do I need to add dump.log in logback.xml when doing the code generation like "audit.log"?
There was a problem hiding this comment.
@BalloonWen Good point, i hadn't considered that. Yeah i think codegen should include the dump.log reference. @stevehu what do you think?
content/concern/dump.md
Outdated
|
|
||
| This is a generic dump handler may be useful to troubleshooting in developing/testing environment. | ||
|
|
||
| This handler is not suggested to be used on production because it will impact the overall performance. |
There was a problem hiding this comment.
I think this is already said on line 13.
whoamnick
approved these changes
Dec 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-documentation for networknt/light-4j#328