Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inject additional spec to origin spec at the start up #170

Merged
merged 5 commits into from Feb 17, 2021

Conversation

BalloonWen
Copy link
Contributor

resolves #169
right now the specification will be injected from openapi-inject.yml at the start up
the injected value will:

  • add to the map if original map doesn't has this key
  • overwrite the original value has the same key
  • add all new to the origin list

- support openapi injection at the runtime
- now the inject value can overwrite the original one
- added tests
Copy link
Contributor

@stevehu stevehu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BalloonWen As we have discussed, we need to add the validation to avoid duplicated paths before merging. Other than that, it looks good to me.

- validate duplicate path before injection
- handled the scenario when no spec to inject
- now will validate based on the path with method
@stevehu stevehu merged commit 03c1c65 into master Feb 17, 2021
@stevehu stevehu deleted the feat/#169-spec-inject branch February 17, 2021 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

automatically inject admin endpoints to the specification at runtime
3 participants