Fixed validation of path parameters and query parameters #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following schema in specification can work properly - minimum - maximum - enum - pattern - minItems - maxItems
|
Linking to dependent PR: networknt/json-schema-validator#113 |
whoamnick
reviewed
Jan 21, 2019
openapi-validator/src/main/java/com/networknt/openapi/RequestValidator.java
Outdated
Show resolved
Hide resolved
openapi-validator/src/main/java/com/networknt/openapi/RequestValidator.java
Show resolved
Hide resolved
openapi-validator/src/main/java/com/networknt/openapi/RequestValidator.java
Show resolved
Hide resolved
…eParamValue` - Added comments to explain why would we check the length of queryParameterValues. - Added comments to explain why/when we need to validate the queryParameterValues directly instead of check its elements.
whoamnick
approved these changes
Jan 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@NicholasAzar @stevehu Since the RequestValidator depends on json-schema-validator. There is another PR related to this issue can be found in networknt/json-schema-validator repo. These changes in different repo contributions to the same issue.
RFC which specifies the details of fix can be found here: https://github.com/networknt/light-rfcs/blob/master/light-rest-4j/0001-openapi-validator-bug-fix.md