added Response Validator to validate response content #69
Conversation
-test cases will use ResponseValidator instead of HandlerTestBase, thus removed it.
-now deserialize content string before do validation -fixed a issue when matching a given uri with schema, now remove query parameters from uri -changed some testing content
|
@BalloonWen @ddobrin I have linked this PR to the open issue #27 as the PR is resolving it. Thanks. |
|
@stevehu: @BalloonWen and I have discussed this and there are multiple aspects which have to be added for the request validator. The code requires also a unit test for it. This code will be tested first, as discussed with @BalloonWen and then additional comments will be provided in due time |
There was a problem hiding this comment.
This PR has been tested offline together with its associated change in the light-codegen.
It can be merged at this time.
It is missing a test case and issue:
#27
... is not addressed completely. That issue requires also a handler, test cases as well as the ability to add validation in the client.
Nevertheless, the gap here can be handled as part of resolving issue #27 and this PR should be merged together with the light-codegen one
related issue: networknt/light-codegen#133
resolved issue: #27