Feat/response validation in ValidatorHandler #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-added one method call interface for validation to use HttpServerExchange -added test cases
whoamnick
approved these changes
May 17, 2019
stevehu
approved these changes
May 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related issue: #89
-Added response validation in validator handler.
-Added a config "validateResponse" in openapi-validator.yml to enable/disable response validation feature.
-When there's a validation error of response, it will only log the error. It cannot send the error back to the client because the response is already completed. Until we change the mechanism of sending a response, I think this is the only way.
-This feature is only suggested to be used in dev/sit environment due to multiple times duplicated serialization/deserialization.
-This feature should not affect any existing behaviours since it only adds a callback logging when the response completed.