Fix i/o timeout error #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: denis-tingajkin <denis.tingajkin@xored.com>
Signed-off-by: denis-tingajkin <denis.tingajkin@xored.com>
Signed-off-by: denis-tingajkin <denis.tingajkin@xored.com>
denis-tingaikin
force-pushed
the
fix_issue_14
branch
from
e06d269
to
237ddfd
Compare
|
需要添加 |
Signed-off-by: denis-tingajkin <denis.tingajkin@xored.com>
|
@snakwu I've added clarification. Please check README.md change. |
haiodo
reviewed
Apr 6, 2020
那我需要怎么配置这个参数？ |
|
@snakwu |
ok,thx!等待合并中，之前提到的except算法问题，有消息么？我自己对比过修改forward为map模式，效果肯明显！ |
add `timeout` option. Signed-off-by: denis-tingajkin <denis.tingajkin@xored.com>
denis-tingaikin
force-pushed
the
fix_issue_14
branch
from
e0c403d
to
550d87e
Compare
Signed-off-by: denis-tingajkin <denis.tingajkin@xored.com>
|
为什么还没合并？？ |
|
@haiodo pls PR this，thx！ |
|
@denis-tingajkin 为什么一直没合并，我期待着测试，谢谢！ |
haiodo
approved these changes
Apr 7, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For real cases, one fail attempt to connect may not guarantee that the upstream server is broken.
We also need to handle the case when the server is busy.
Motivation
#14