Fanout plugin: Improve except option #17
Conversation
denis-tingaikin
force-pushed
the
improve_except
branch
from
f9025d1
to
424dc48
Compare
|
Very cool！！！ |
denis-tingaikin
force-pushed
the
improve_except
branch
from
424dc48
to
32287aa
Compare
Signed-off-by: denis-tingajkin <denis.tingajkin@xored.com>
denis-tingaikin
force-pushed
the
improve_except
branch
from
32287aa
to
911d341
Compare
| require.Nil(t, d.Get(".").Get("com").Get("example").Get("advanced")) | ||
| } | ||
|
|
||
| func BenchmarkDomain_ContainsMatch(b *testing.B) { |
There was a problem hiding this comment.
This test prints ~20 ms for 10 000 entries.
And the test prints ~103 s for the previous realization.
NOTE: Max segment count of the domain in the test is 100.
The current complexity of this solution is O(n) where n is the number of segments. This means it should work faster in the real world than in these bench tests.
为什么等了这么信还没合并呢？太期待这功能了！ |
Signed-off-by: denis-tingajkin denis.tingajkin@xored.com
Description
Currently
exceptoption has O(n*m) (where n is the number of exclude domain names and m is the number of parts of the domain name) time to checking request domain name. The current solution is not ideal for the real world and it should be improved to make it work fast for cases with more than 10 000 entries.Motivation
#12