Extend CI: Add possible to build and push Coredns image with fanout plugin #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denis-tingaikin
force-pushed
the
extend_ci
branch
4 times, most recently
from
f2c1e8f
to
100d004
Compare
denis-tingaikin
force-pushed
the
extend_ci
branch
from
1b69b5b
to
0a3bdb7
Compare
edwarnicke
reviewed
Mar 19, 2020
| @@ -0,0 +1,4 @@ | |||
| FROM alpine as runtime | |||
There was a problem hiding this comment.
Is there a reason this is in the coredns/ subdir instead of the top level directory?
There was a problem hiding this comment.
top-level directory is related to the package fanout. If we put all files from this directory to top-level directory then we face with Multiple packages in directory error.
There was a problem hiding this comment.
Also, information aboutfanout plugin coredns/coredns.io#190 has been merged into Coredns website and soon this plugin can be used by people. And I think we should not add main.go file for fanout module because it can break the mechanism of Caddyserver for loading external plugins.
denis-tingaikin
force-pushed
the
extend_ci
branch
from
0a3bdb7
to
5db023e
Compare
Signed-off-by: denis-tingajkin <denis.tingajkin@xored.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: denis-tingajkin denis.tingajkin@xored.com
Motivation
#3