Skip to content
This repository has been archived by the owner on Oct 29, 2021. It is now read-only.

Modified title to show AWS instead of GCP #2251

Merged
merged 1 commit into from
May 21, 2021

Conversation

juangascon
Copy link
Contributor

Description

The document title said to register inside GCP while we are in the AWS guide.

Motivation and Context

The document is about AWS and GCP is mentioned at its place.
It solves incoherence between title and real context

How Has This Been Tested?

  • Covered by existing integration testing
  • Added integration testing to cover
  • Tested locally
  • [ X ] Have not tested

Test not really necessary. It is a small change in the documentation. All tests should pass as before.

Types of changes

  • [ X ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • [ X ] My change requires a change to the documentation.
  • [ X ] I have updated the documentation accordingly.

@edwarnicke
Copy link
Member

@juangascon Could you add a signed off by line for DCO using

git commit -s --amend --no-edit;git push -f

@juangascon
Copy link
Contributor Author

How I do that? Should I clone this repo and use the commands you show me?

The document title said to register inside GCP while we are in the AWS guide.

Signed-off-by: Gascon Juan <juan.gascon@orange.com>
Signed-off-by: Gascon Juan <juan.gascon.gonzalez@gmail.com>
@edwarnicke edwarnicke merged commit fea0424 into networkservicemesh:master May 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants